Details
-
Bug
-
Resolution: Fixed
-
Major
-
None
-
None
Description
1) There is now a file reference from the MusicMetadataExtractor to the DLL file "..\..\..\..\Bin\MP-II-Client\bin\x86\Debug\Plugins\TagLibPlugin\TagLib.dll". Should be replaced by a reference to the TagLibPlugin itself.
2) Media resource access was broken by this change:
Index: D:/Projekte/Visual C#/MediaPortal/MP-Server/Source/Media/MetadataExtractors/MusicMetadataExtractor/MusicMetadataExtractor.cs
===================================================================
--- D:/Projekte/Visual C#/MediaPortal/MP-Server/Source/Media/MetadataExtractors/MusicMetadataExtractor/MusicMetadataExtractor.cs (revision 24525)
+++ D:/Projekte/Visual C#/MediaPortal/MP-Server/Source/Media/MetadataExtractors/MusicMetadataExtractor/MusicMetadataExtractor.cs (revision 24526)
@@ -204,8 +204,7 @@
File tag;
try
{
- tag = File.Create(new MediaProviderFileAbstraction(mediaItemAccessor),
- Path.GetFileName(humanReadablePath), null, ReadStyle.Fast);
+ tag = File.Create(humanReadablePath);
}
catch (CorruptFileException)
{
The change is invalid and must be reverted. If the new TagLibPlugin doesn't support the file access via that file abstraction any more, it needs to be added.
2) Media resource access was broken by this change:
Index: D:/Projekte/Visual C#/MediaPortal/MP-Server/Source/Media/MetadataExtractors/MusicMetadataExtractor/MusicMetadataExtractor.cs
===================================================================
--- D:/Projekte/Visual C#/MediaPortal/MP-Server/Source/Media/MetadataExtractors/MusicMetadataExtractor/MusicMetadataExtractor.cs (revision 24525)
+++ D:/Projekte/Visual C#/MediaPortal/MP-Server/Source/Media/MetadataExtractors/MusicMetadataExtractor/MusicMetadataExtractor.cs (revision 24526)
@@ -204,8 +204,7 @@
File tag;
try
{
- tag = File.Create(new MediaProviderFileAbstraction(mediaItemAccessor),
- Path.GetFileName(humanReadablePath), null, ReadStyle.Fast);
+ tag = File.Create(humanReadablePath);
}
catch (CorruptFileException)
{
The change is invalid and must be reverted. If the new TagLibPlugin doesn't support the file access via that file abstraction any more, it needs to be added.