Details
Description
<p>1. ACTION_CDEJECT doesn't work.</p>
<p>The action has no effect when triggered by [for example] mapping the action to the eject button on a remote control.</p>
<p>This appears to have been broken byMP1-2469 (merged for MP 1.6 final), when the mciSendString() implementation of <span class="pl-en">EjectCDROM</span>() was replaced with reuse of the <span class="pl-en">EjectCDROM</span>(string) function. The idea to reuse code is good. Unfortunately <span class="pl-en">EjectCDROM(string)</span> doesn't actually work when you pass empty string.</p>
<p>2. The "eject" context menu item in the music and pictures plugins doesn't work when the drive does <b>not </b>contain a disc.</p>
<p>The menu item works when the drive contains a disc, and will also close the tray if the tray is open. However it won't open the tray if the drive is empty.</p>
<p>Note that this aspect of the issue doesn't affect the videos plugin. In that case the eject menu item will only open the tray, and it works regardless of whether the drive contains a disc or not.</p>
<p>3. ACTION_CDEJECT doesn't trigger ejecting the selected drive from the videos, pictures or music plugins.</p>
<p>Logically it would make sense to be able to use the eject button on the remote to eject/open the selected/focussed disc/drive. In practice, because the implementation is contained in the main class WndProc(), there is no "selected item" context to use for choosing the correct disc/drive.</p>
<p> </p>
<p>All of the above problems are addressed by this issue.</p>
<p>The action has no effect when triggered by [for example] mapping the action to the eject button on a remote control.</p>
<p>This appears to have been broken by
<p>2. The "eject" context menu item in the music and pictures plugins doesn't work when the drive does <b>not </b>contain a disc.</p>
<p>The menu item works when the drive contains a disc, and will also close the tray if the tray is open. However it won't open the tray if the drive is empty.</p>
<p>Note that this aspect of the issue doesn't affect the videos plugin. In that case the eject menu item will only open the tray, and it works regardless of whether the drive contains a disc or not.</p>
<p>3. ACTION_CDEJECT doesn't trigger ejecting the selected drive from the videos, pictures or music plugins.</p>
<p>Logically it would make sense to be able to use the eject button on the remote to eject/open the selected/focussed disc/drive. In practice, because the implementation is contained in the main class WndProc(), there is no "selected item" context to use for choosing the correct disc/drive.</p>
<p> </p>
<p>All of the above problems are addressed by this issue.</p>
Attachments
Issue Links
- relates to
-
MP1-2469 DetectDrive method obsolete
-
- Closed
-
- links to