Uploaded image for project: 'MediaPortal 1'
  1. MediaPortal 1
  2. MP1-4203

TS 'PacketSync' code does not handle small//fragmented buffers correctly

    XMLWordPrintable

Details

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Major Major
    • 1.5.100
    • 1.4.0, 1.5 Pre-Release
    • TsReader, TsWriter
    • None

    Description

      <p>The 'OnRawData()' and OnRawData2()' methods in PacketSync.cpp - which is the input TS packet parser - do not handle small/fragmented input buffers correctly in some situations, resulting in lost data and continuity errors (particularly when using TsReader.ax with RTSP or UNC path options for live TV).</p><p>Discussion thread (with test versions) is at - <a data-cke-saved-href="http://forum.team-mediaportal.com/threads/livetv-freezes-and-shows-a-lot-of-artifacts.117848/page-9" href="http://forum.team-mediaportal.com/threads/livetv-freezes-and-shows-a-lot-of-artifacts.117848/page-9">http://forum.team-mediaportal.com/threads/livetv-freezes-and-shows-a-lot-of-artifacts.117848/page-9&lt;/a&gt;&lt;/p&gt;&lt;p&gt;Branch with modified OnRawData2() method used in TsReader.ax is at <a data-cke-saved-href="https://github.com/MediaPortal/MediaPortal-1/tree/MP1-EXP_TsReader_PacketSync" href="https://github.com/MediaPortal/MediaPortal-1/tree/MP1-EXP_TsReader_PacketSync">https://github.com/MediaPortal/MediaPortal-1/tree/MP1-EXP_TsReader_PacketSync&nbsp; </a><strong>&nbsp;&nbsp; Note</strong> - this branch contains other modifications in addition.</p><p><strong>Note</strong> - TsWriter.ax (and some other filters) use the OnRawData() method, but a version of TsWriter.ax has been built and tested sucessfully which uses OnRawData2().</p>

      Attachments

        Activity

          People

            Owlsroost Owlsroost (Inactive)
            Owlsroost Owlsroost (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: